Issues for Mailing list of the Concrete Syntax for a UML Action language for Foundational UML (ALF)

List of issues (green=resolved, yellow=pending Board vote, red=unresolved)

List options: All ; Open Issues only; or Closed Issues only

Issue 15625: The Model file includes the UML Primitive Types package rather than referencing it.
Issue 15626: Need to replace the CMOF file for the abstract syntax by a UML file for UML 2.4
Issue 16006: StructuredMember should be renamed to StructuredElement
Issue 16015: Correction to Section 8.3.6, Property Access Expressions
Issue 16028: [ALF] Issue with Section 8.3.6 - Invocation Expressions
Issue 16413: Null Template Binding Arguments
Issue 16414: Boolean Literals Cannot Be Used as Identifiers
Issue 16415: Error in Synthesis of Null Expressions
Issue 16416: Parenthesizing Left Hand Sides
Issue 16417: Missing Cross Reference in Subclause 9.6
Issue 16418: Evaluation of Loop Variable Definitions
Issue 16419: Return Statements with no Expression
Issue 16420: Implicit Imports
Issue 16421: Error in Singleton Examples
Issue 16422: Error in ProcessQueue Example
Issue 16423: Constructors and Diamond Inheritance
Issue 16424: Synthesis of the Name of a Reception Definition
Issue 16425: IndexOf Return Type
Issue 16426: Errors in Collection Function Table
Issue 16429: Errors in Abstract Syntax Attribute Names
Issue 16431: Type Conformance for Compound Assignments for Bit Strings
Issue 16432: Errors in BehaviorInvocationExpression Constraints
Issue 16434: binaryExpressionOperandMultiplicity Constraint is Too Strong for EqualityExpression
Issue 16435: Derived Attributes for LeftHandSide
Issue 16436: Require Non-Template Classifier
Issue 16437: Corrections to updateAssignments for ConditionalTestExpression
Issue 16439: Constraint Needed on FeatureLeftHandSide
Issue 16440: Derivations of type, lower and upper for Invocation Expressions
Issue 16441: Corrections to InvocationExpression::parameterElements
Issue 16442: literalExpressionTypeDerivation Is Not Necessary
Issue 16443: Errors in LogicalExpression Constraints
Issue 16444: Problem with the NamedExpression Conversion Constraints
Issue 16445: NamedTuple Needs a Constraint
Issue 16447: NameExpression Should Override updateAssignments
Issue 16448: Problems with NameLeftHandSide Constraints
Issue 16449: PositionalTuple Needs a Constraint
Issue 16450: Error in propertyAccessExpressionLowerDerivation
Issue 16451: QualifiedName::templateName Needs a Description
Issue 16452: Error in qualifiedNameDisambiguationDerivation
Issue 16453: SequenceConstructionExpression::typeName May Be Empty
Issue 16454: SequenceConstructionExpression Constraints
Issue 16455: SequenceConstructionExpression Needs to Override updateAssignments
Issue 16456: SequenceOperationExpression Should Override parameterElements
Issue 16457: SequenceOperationExpression Constraints
Issue 16458: Correction to shiftExpressionOperands Constraint
Issue 16459: Correction to superInvocationExpressionTarget Constraint
Issue 16460: Block Assignment Constraints
Issue 16462: ForStatement Should Have a Composition Association to Block
Issue 16463: localNameDeclarationStatementAssignmentsAfter constraint
Issue 16464: Derivation of LocalNameDeclaration::type
Issue 16467: SwitchClause Should Have a switchClauseCase Constraint
Issue 16468: Errors in Descriptions of SwitchStatement constraints
Issue 16469: ElementImportReference Constraint
Issue 16470: Errors in ImportedMember
Issue 16472: NamespaceDefinition::ownedMember Should Be Ordered
Issue 16473: Description of operationDefinitionRedefinition
Issue 16474: Constructor Return Type
Issue 16476: Assignments Before a Property Initializer
Issue 16477: Description of SignalDefinition::isSameKindAs
Issue 16478: Errors in Constraint Names
Issue 16479: Errors in QuickSort Example
Issue 16480: Errors in the Online Bookstore Example
Issue 16481: Errors in the Property Management Service Example
Issue 16482: Errors in the Collection Classes Implemenation
Issue 16586: Typo in sequence functions?
Issue 16591: Problem with parameters of CollectionFunctions::removeAll
Issue 16592: Problem with parameters of CollectionFunctions::replaceOne
Issue 16606: Should be allowed to use return statement in all behaviors
Issue 17508: Errors in Subclause 8.2
Issue 17510: Error in Data Value Creation Expression
Issue 17511: SequenceExpressionList::element should be ordered
Issue 17513: Error in bit string conversion
Issue 17514: @determined should be @determinate
Issue 17515: Inconsistency on being constructorless
Issue 17516: AssignmentExpression as a data value update
Issue 17517: Error in AssignmentExpression constraints
Issue 17518: Constructor in a BehaviorInvocationExpression
Issue 17519: Referent of a signal send
Issue 17520: Indexed feature left hand sides
Issue 17521: InstanceCreationExpression class must not be abstract
Issue 17522: Assigned name must not be template binding
Issue 17523: Derivation of SequenceOperationExpression::isCollectionConversion
Issue 17524: Assignment of out parameters in if and switch statements
Issue 17525: Classifier behavior required for an active class
Issue 17526: Inherited abstract operations

Issue 15625: The Model file includes the UML Primitive Types package rather than referencing it. (alf-ftf)

The Model file includes the UML Primitive Types package rather than referencing it.

issue15625

Need to replace the CMOF file for the abstract syntax by a UML file for UML 2.4

In order to play with ALF I have thrown together a parser for my own use.
Along the way I have found a small error in the spec regarding the Abstract  Syntax for ALF. Many clauses in the spec (Beta 1) refer to 'StructuredElement' and those same  clauses say  that StructuredElement is defined in clause 10.4.4. However, in clause 10.4.4 the element appears to be named 'StructuredMember' instead.


It looks to me like StructuredMember should be renamed to StructuredElement since the term 'Element' appears to be the convention used throughout the rest of the spec.

There is a small problem in section 8.3.6 regarding property access expressions.
The problem is that the concrete syntax defined in that section will not 
actually match the examples given in that section.


---------
Here is the concrete syntax defined in that section...


    PropertyAccessExpression(e: PropertyAccessExpression)
     = FeatureReference(e.featureReference)


   FeatureReference(f: FeatureReference)
     = FeatureTargetExpression(f.expression) "." NameBinding(f.nameBinding)


   FeatureTargetExpression(e: Expression)
     = NameTargetExpression(e)
     | NonNamePrimaryExpression(e)


   NameTargetExpression(e: NameExpression)
    = ColonQualifiedName(e.name)


Note that NameTargetExpression only allows ColonQualifiedName(s) to be used to 
define a PropertyAccessExpression.


-------
Here are the examples of property access expressions from the same section...
   
    poleValue.im
    this.node
    members.name
    jack.house


Note that, because NameTargetExpression only allows ColonQualifiedName(s), none 
of the above examples matches the concrete syntax.


----------
I suspect that NameTargetExpression should be defined to be a QualifiedName, 
which is defined to be either a DotQualifiedName, an UnqualifiedName, or a 
ColonQualifiedName, so...


   NameTargetExpression(e: NameExpression)
    = QualifiedName(e.name)


where QualifiedName is defined elsewhere as:


QualifiedName(q: QualifedName)
= ColonQualifiedName(q)
| DotQualifiedName(q)
| UnqualifiedName(q)

The abstract syntax defined in Section 8.3.7 (Invocation Expressions) and 
Section 8.3.9 (Behavior Invocation Expressions) will not match this 
expression...
 
    this.monitor.getActiveSensor().getReading()


(NOTE: the above expression is used as an example in Section 8.5.6 - Isolation 
Expressions)
 
The issue seems to be that the definition of InvocationExpression does not 
repeat.


Here is the current definition for InvocationExpression...
 
        InvocationExpression= InvocationTarget Tuple
        InvocationTarget= BehaviorInvocationTarget 
            | FeatureInvocationTarget 
            | SuperInvocationTarget


 
Maybe the definition for InvocationTarget should be something like this?...
 
        InvocationExpression= InvocationTarget Tuple { "." InvocationTarget 
Tuple }

Subclause: 6.2 Templates

The rule in Subclause 6.2 for constructing the name of an equivalent bound element does not account for the possibility that one of the arguments may be null (i.e., “any”). While the syntax for template bindings in qualified names (Subclause 8.2) does not allow “any” to be used as a template argument, such an argument can result from the rules for the implicit binding for a template behavior as given in Subclause 8.3.9.

Subclause 7.5: Names

Subclause 7.5 should says that reserved words cannot be used as identifiers, but it should also note that Boolean literals (which are not classified as reserved words) can also not be used as identifiers.

Subclause: 8.3.15: Sequence Construction Expressions

In Subclause 8.3.15, the parsing of a NullExpression should set the hasMultiplicity=true for the SequenceConstructionExpression, otherwise the derivation of the lower and upper attributes (see Subclause 13.2.46) will result in those both being 1 instead of both being 0.

agreed

Subclause: 8.8 Assignment Expressions

It should be allowed to parenthesize a left hand side. This makes it possible to parse the left hand side simply as an expression and then check afterward if it is correct (as is done in the grammar given in the annex). It is also consistent with Java syntax.

Subclause: 9.6 Local Name Declaration Statements

Subclause 9.6 should have a cross reference to the abstract syntax class InstanceCreationExpression, since the InstanceInitializationExpression production creates an instance of that class.

Subclause: 9.12 for Statements

It should be made clear that the expressions in the loop variable definitions of a for statement are evaluated sequentially in the order of the loop variables (per the mapping). (Or, if the expressions are evaluated concurrently, then there needs to be a constraint that the same name cannot be assigned in more than one of those expressions.)

Subclauses: 9.14 return Statements
A return statement without an expression should be allowed for a behavior without a return parameter.

Subclause: 10.1 Overview

It is only necessary to require implicit imports of standard model library packages into model units. Any direct or indirect subunits of a model library unit with implicit imports will have visibility upwards of the packages imported into the model unit. Also, applying «ModelLibrary» to a subunit cannot prevent this visibility of the standard model library packages, and so this stereotype is also actually only effective on a model unit.

Subclause 10.4.2 Classes

In the Singleton example use in Subclause 10.4.2 under Semantics, “allinstances” should be “allInstances”.

Subclause: 10.4.3 Active Classes

In the ProcessQueue example in Subclause 10.4.3, “sign” that appears twice in the classifier behavior should be “sig”.

Subclause: 10.5.3.1 Constructors

At the end of Subclause 10.5.3.1 it states that: “In the absence of explicit constructor invocations at the start of a constructor body (and also in the case of the default constructor behavior), a super constructor invocation is made implicitly for each immediate superclass, in the order the superclasses appear in the specializes list of the class containing the constructor, before executing any statements in the constructor body.” However, if the immediate superclasses themselves have common ancestors (so called “diamond inheritance”), applying this rule recursively will result in the constructors of these common ancestors being called multiple times.

Subclause 10.5.4: ReceptionDefinition

In the syntax for ReceptionDefinition, the condition for d.name should be {d.name=d.signal.nameBinding->last().name}.

Subclause: 11.3.6 Sequence Functions

In Table 11-14, the return type of IndexOf should be Integer, not any.

Subclause: 11.5 Collection Functions

In Table 11-15, “ordered nonuique” [sic] appears twice (first column, second and third rows) and should be replaced with “sequence”. remove, removeAll and removeOne should return “T[*] sequence”.

Subclauses: 13.2.31 NamedExpression, 15.2.9 EnumerationDefinition, 15.2.15 NamespaceDefinition, and 15.2.16 OperationDefinition

•	NamedExpression::isBitStringConverstion should be isBitStringConversion
•	EnumerationDefinition::classDefinitionSpecializationReferent should be enumerationDefinitionSpecializationReferent
•	NamespaceDefinition::annotationAllowed should not be abstract.
•	OperationDefinition::redefinedOperations should be redefinedOperation

Subclause: 13.2.2

The assignmentExpressionCompoundAssignmentTypeConformance constraint should also handle compound assignments for bit string operators.

Subclause: 13.2.3 BehaviorInvocationExpression

•	The behaviorInvocationExpressionReferentDerivation should allow for resolution of the target to an association end.

•	The behaviorInvocationExpressionArgumentCompatibility constraint should note that it only applies if the target does not disambiguate to a feature reference.

Subclause: 13.2.4

The binaryExpressionOperandMultiplicity constraint requires that the operands of a binary expression have a multiplicity upper bound of 1. However, an equality expression (a kind of binary expression) is allowed to compare to “null”, which has a multiplicity upper bound of zero.

Subclause: 13.2.6 LeftHandSide

A left hand side should have derived type, lower and upper attributes, since these are defined in Subclause 8.8.

Subclauses: 13.2.8 CastExpression and 13.2.10 Classification Expression

The castExpressionTypeResolution and classificationExpressionTypeName constraints should require a non-template classifier

Subclause: 13.2.13 ConditionalTestExpression

The description of the updateAssignments operation for ConditionalTestExpression should clearly state that assignments can be made in the first operand expression. It should also state that the type of newly defined names is the effective common ancestor of the types of the name in each of the second and third operands

Subclause: 13.2.18

There needs to be a constraint on FeatureLeftHandSide that it resolves to a single referent that is a structural feature.

Subclause: 13.2.23 InvocationExpression

The derivations of type, lower and upper inherited in  InvocationExpression are based on the return parameter of the referent of the expression. This doesn’t work for referents that are not behaviors or operations. Specifically:

•	For an InstanceCreationExpression, the referent may be a classifier (Class or DataType), in which case, the type needs to be the referent itself and lower and upper need to both be 1.

•	For a BehaviorInvocationExpression, the referent may be an association end, in which case the type, lower and upper need to be the same as for the end. 

Subclause: 13.2.23 InvocationExpression

•	The return parameter of the InvocationExpression::parameterElements helper operation should be ordered.

•	The definition of InvocationExpression::parameterElements should also handle the case in which the reference is an association end.

Subclause: 13.2.28 LiteralExpression

The constraint literalExpressionTypeDerivation (“The type of a literal expression is given by the type of the literal, as defined for each subclass below.”) is not necessary, since it doesn’t provide any actual constraint. (Plus, in the current document organization, not all of the subclasses are “below” the subclause on LiteralExpression.)

Subclause: 13.2.29 LogicalExpression

•	The definitions of the logicalExpressionIsBitStringConversion1 and logicalExpressionIsBitStringConversion2 constraints mention “shift expression” when they should say “logical expression”.

•	The logicalExpressionOperands constraint should allow for BitString and Integer operands (per the semantics of logical expression in Subclause 8.6.7).

•	The logicalExpressionTypeDeriviation constraint should give the type BitString if the expression is bit-wise.

Subclause: 13.2.31 NamedExpression

The constraints namedExpressionIsBitStringConversion and namedExpressionIsCollectionConversion cannot really be checked within the context of NamedExpression, since there is no way from that context to determine what the type of the “corresponding parameter” is.

Subclause: 13.2.33 NamedTuple

NamedTuple should have a constraint that its argument names all correspond to parameter names of its invocation and that no argument name appears more than once.

Subclause: 13.2.34 NameExpression

NameExpression should override updateAssignments to return the assignments after its derived propertyAccess expression, if it has one (i.e., if it disambiguates to a feature reference).

Subclause: 13.2.35 NameLeftHandSide

•	There needs to be a constraint on NameLeftHandSide that if its name is qualified, and does not disambiguate to a feature, then it resolves to a parameter of the behavior containing the left-hand side, and, if it disambiguates to a feature, it resolves to a single referent that is a structural feature.

•	In the nameLeftHandSideAssignmentAfterDerivation constraint, if the named left hand side has an index, then the assignments after the left hand side should be the assignments after the index.

•	The derivations for assignmentBefore and assignmentAfter for NameLeftHandSide need to account for the possibility of the name disambiguating to a feature reference

Subclause: 13.2.40 PositionalTuple

PositionalTuple should have a constraint that it does not have more arguments than its invocation has parameters.

Subclause: 13.2.41 PropertyAccessExpression

The propertyAccessExpressionLowerDerivation constraint description refers to upper bounds when it should refer to lower bounds

Subclause: 13.2.42 QualifiedName
QualifiedName::templateName needs a description

Subclause: 13.2.42 QualifiedName

In the description of qualifiedNameDisambiguationDerivation, “If a qualified name is not ambiguous or it resolves to a namespace…” should be “If a qualified name is not ambiguous or it has a qualification that resolves to a namespace…”

Subclause: 13.2.46 SequenceConstructionExpression

The description of the sequenceConstructionExpressionType constraint should make it clear that it is legal for the typeName property to be empty (corresponding to a type name notation of “any”).

Subclause: 13.2.46 SerquenceConstructionExpression

•	SequenceConstructionExpression needs constraints on the type and multiplicity of its sequence elements. However, the rules here (and as stated in Subclause 8.3.15) need to allow for bit string conversion of integer elements for a bit string sequence.

•	The description of the sequenceExpansionExpressionVariableSourceDerivation constraint should also state that the type of the assigned source for the expansion variable is the type of the primary expression and the multiplicity bounds are both 1.

•	SequenceExpansionExpression needs a constraint that no names defined before the argument expression may be reassigned in the argument expression (per the Semantics in Subclause 8.3.19), not just the expansion variable.

•	The description of the sequenceExpansionExpressionListUpperDerivation constraint says “lower bound” when in should say “upper bound”.

Subclause: 13.2.46 SequenceConstructionExpression

SequenceConstructionExpression needs to override updateAssignments. For a sequence expression list, the assignments before each element expression should be the assignment after the previous one and the assignments after the sequence construction expression are the assignments after the last element expression. For a sequence range the assignments before both expressions are the assignments before the sequence construction expression and the assignments after the sequence construction expression are the assignments after the expressions. There should also be a constraint on sequence ranges that the same local name cannot be assigned in both expressions

Subclause: 13.2.50 SequenceOperationExpression

SequenceOperationExpression should override the parameterElements operation to only return the parameters after the first, since the argument for the first parameter is given by the primary expression not in the tuple.

Subclause: 13.2.50 SequenceOperationExpression

•	SequenceOperationExpression needs a constraint that a name may not be assigned in both the primary expression and any tuple argument expression.

•	SequenceOperationExpression should have a derived association with an optional LeftHandSide that is created in the case of an “in place” operation and must have its constraints satisfied. The sequenceOperationExpressionTargetCompatibility constraint should also require that, for an “in place” operation, the primary expression have the form of a left-hand side and, if for a local name, the local name must already exist. 

Subclause: 13.2.53 ShiftExpression

The description of the shiftExpressionOperands constraint should say “The first operand expression of a shift expression must have the type BitString or Integer. The second operand expression must have the type Integer.” (per Subclause 8.6.3).

Subclause: 13.2.55 SuperInvocationExpression

The superInvocationExpressionImplicitTarget constraint should include the condition that the containing behavior has only a single superclass

Subclause: 14.2.4 Block

•	The second sentence of the description of the Block::assignmentAfter derived property mentions “statement” twice when it should say “block”.

•	The blockAssignmentsBefore constraint should have the definition “The assignments before the first statement of a block are the same as the assignments before the block.”

Subclause: 14.2.12 for Statements

ForStatement should have a composition association with its body Block.

Subclause 14.2.15 LocalNameDeclarationStatement

The localNameDeclarationStatementAssignmentsAfter constraint states “The assignments after a local name declaration statement are the assignments before the statement plus a new assignment for the local name defined by the statement.” The assignments should be the assignments after the expression of the statement plus the new assignment (so as to include assignments made in the expression).

Subclause: 14.2.15

The localNameDeclarationTypeDerivation requires the type of the statement to be the type of the expression if no type name is given. However, this is not correct, since the only way that the type name could be empty is if it is given as “any”, in which case the local name should be untyped.

Subclause: 14.2.21 SwitchClause

SwitchClause should have a switchClauseCases constraint the states “All the cases expressions of a switch clause must have a multiplicity no greater than 1.”

Subclause: 14.2.22

•	The description of the switchStatementExpression constraint should be “The expression of a switch statement must have a multiplicity no greater than 1.” 

•	The description of the switchStatementEnclosedStatements constraint should be “A switch statement is the enclosing statement for the statements in all of its switch clauses.”

•	The switchStatementAssignmentsBefore constraint should state that the assignments before the clauses of a switch statement are the assignments after the expression of the switch statement.

Subclause: 15.2.8 ElementImportReference

ElementImportReference should have a constraint that its referent must be a packageable element.

Subclause: 15.2.12 ImportedMember

•	The description of ImportedMember::isSameKind is written in terms of distinguishability rather than same kind.

•	An ImportedMember should not generally be considered a feature, even if it is a feature of the namespace it is imported from, since it is not a feature of the namespace it is imported into.

Subclause: 15.2.15 NamespaceDefinition

NamespaceDefinition::ownedMember association should be ordered. (This is important at least for activity and operation parameters.)

Subclause: 15.2.16 OperationDefinition

In the description of OperationDefinition::operationDefinitionRedefinition, “signal referent” should be “single referent”.

Subclause: 15.2.16 OperationDefinition

OperationDefinition must take into account that the return type of a constructor is not explicitly declared, but is still included in the operation signature (per Subclause 10.5.3.1).

Subclause: 15.2.19 PropertyDefinition

The propertyDefinitionInitializer constraint should also state that there are no assignments before the initializer expression.

Subclause: 15.2.21 SignalDefinition

The description of SignalDefinition::isSameKindAs mentions “Reception” where it should say “Signal”.

Subclauses: Various subclauses in Part III Abstract Syntax

The following constraint names should be corrected as shown:
•	expressionAssignmentsAfterDerivation -> expressionAssignmentAfterDerivation 
•	bitStringUnaryExpresionIsBitStringConversionDerivation -> bitStringUnaryExpressionIsBitStringConversionDerivation 
•	loopVariableIsCollectionConversionDerivation -> loopVariableDefinitionIsCollectionConversionDerivation 
•	importedElementNotStub -> importedMemberNotStub 
•	importedElementFeatureDerivation -> importedMemberIsFeatureDerivation 
•	forAllOrExistOrOneExpressionTypeDerivation -> forAllOrExistsOrOneExpressionTypeDerivation 
•	forAllOrExistOrOneExpressionLowerDerivation -> forAllOrExistsOrOneExpressionLowerDerivation 
•	forAllOrExistOrOneExpressionUpperDerivation -> forAllOrExistsOrOneExpressionUpperDerivation 
•	forAllOrExistOrOneExpressionArgument -> forAllOrExistsOrOneExpressionArgument 
•	relationalExpressionIsTypeDerivation -> relationalExpressionTypeDerivation 
•	relationalExpressionIsLowerDerivation -> relationalExpressionLowerDerivation 
•	relationalExpressionIsUpperDerivation -> relationalExpressionUpperDerivation 
•	unboundedLiteralExpressionDerivation -> unboundedLiteralExpressionTypeDerivation 
•	namespaceDefinitionMemberDistinguishaibility -> namespaceDefinitionMemberDistinguishability 
•	operationDefinitionIsConstructorDefinition -> operationDefinitionIsDestructorDerivation 
•	operationDefinitionIsDestructorDefinition -> operationDefinitionIsDestructorDerivation 
•	operationDefinitionRedefinedOperationsDerivation -> operationDefinitionRedefinedOperationConstraint 
•	propertyDefinitionIsBitStringConversion -> propertyDefinitionIsBitStringConversionDerivation 
•	incrementOrDecrementExpressionIsDataValueUpdate -> incrementOrDecrementExpressionIsDataValueUpdateDerivation 
•	incrementOrDecrementExpressionFeature -> incrementOrDecrementExpressionFeatureDerivation 
•	incrementOrDecrementExpressionAssignment -> incrementOrDecrementExpressionAssignmentDerivation 

Subclause: C.1 Quicksort Activity

In the “functional” QuickSort example:
•	x cannot be set only in the else part of an if statement
•	The sequence operation “remove” should be “removeAt” 
•	The recursive call to “QuickSort” should be “Quicksort”.

Subclause: C.2 Online Bookstore

•	In the example class Order, the statement “accept (OrderDelivery)” should be “accept (OrderDelivered)”. Also, the nested activities have to be operations, because nested activities don’t have the containing class as their context.

•	In the example activity EstablishCustomer, “TIM::current_date” should be replaced with “TIM::GetCurrentDate()”.

•	The ProcessCharge activity should import Ordering::CreditCardCharge::ChargeData.

•	In the graphical model for the Ordering example, the Customer class is shown as having a purchasesMade attribute that is not set in the EstablishCustomer activity, but that activity instead shows a phone attribute being set that is missing from the class.

Subclause: C.3 Property Management Service

•	To be consistent with the implementation of ‘create reply’, the association of Property to Location should be optional.

•	In the ‘create property’ example, the mandatory ‘property type’ needs to be set in the propertyData instance creation expression.

•	In the establish operation, two occurrences of “request.name” should be replaced with “request.’property name’”.

•	In the acquire, update, delete and retrieve operations, the reply and error out parameters need to be set to null values before the if statement and the select expressions should have “[1]” at the end.

•	In the acquire, update and dispose operations, the reference to ‘Property Type’ should be ‘Property Status’ and the assignment in the second if clause should be equality.

•	The update operation needs to import 'Property Management'::'Data Model'::Locations::Location. Also, “request.’property location’” should be “request.’property location identifier’” (three times), “request.’serial number’ “should be “request.’property serial number’” and “request.size” should be “request.’property size’”.

Subclause: C.4 Alf Standard Library Collection Classes Implementation

•	All the collection implementation classes have an incorrect namespace declaration containing “Collections::CollectionClasses”, rather than just “CollectionClasses”. They also import “Alf::Library::FunctionBehaviors::Collections::CollectionFunctions” rather than “Alf::Library::CollectionFunctions”. 
•	Return types should not be given on constructors. 
•	Several classes have destructors that call CollectionImpl<T>::destroy, but CollectionImpl has no such destructor. 
•	The classes that have multiple specializations have to redefine indistinguishable operations inherited from both classes. 
•	In C.4.2 CollectionImpl, 
o	excludesAll and includesAll have seq as their parameter, but incorrectly use the name “element” in their bodies. 
o	In the first statement of removeOne, “self” is used instead of “this”. 
o	In the last statement of retainAll, there should not be “()” after “preSize”. 
•	In C.4.3 OrderedCollectionImpl, 
o	In the body of addAt, the call to “addAllAt” should be proceeded by “this.”. 
o	In the body of indexOf, the reference to “indexof” should be “indexOf”. 
•	In C.4.5 OrderedSet, 
o	In the body of equals, “OrdredCollcetionImpl” should be “OrderedCollectionImpl”. 
o	In the body of subOrderedSet, the constructor “OrderedSet” should be “OrderedSet<T>”. 
•	In C.4.6 Bag, the super constructor call should be to CollectionImpl, not OrderedCollection. 
•	In C.4.7 List, 
o	 CollectionClasses::Impl::List should specialize CollectionClasses::List, not CollectionClasses::OrderedSet. 
o	subList should return List<T>, not OrderedSet<T>. 
o	In subList, the constructor “List” should be “List<T>”. 
o	The parameter for setContent should be a “sequence”. 
•	In C.4.8 Queue, 
o	Queue should specialize CollectionClasses::Queue, not CollectionClasses::Set. 
o	In the body of removeFirst, “toSequence” should be “toSequence()”. 
o	removeFirstOne should have a return multiploicity of 1..1. 
o	The body of removeFirstOne should return the argument element or null, depending on whether the element was actually found for deletion. 
•	In C.4.9 Deque, 
o	Deque should specialize CollectionClasses::Deque in addition to Queue. 
o	The super constructor call should be super.Queue<T>::Queue, not just super, and the super destructor call should be super.Queue<T>::destroy. 
o	The implementation of removeLastOne removes all occurrences of the given element, not just the last one. 
o	toSequence cannot return “this.content”, since “content” is private to Queue. 
o	The (constructor) operation Queue is inherited from both superclasses and must be redefined. 

I think there is a typo page 184:

 

Difference

(in seq1: any[*] sequence,

in seq2: any[*] sequence nonunique):

any[*] sequence

 

it’s not necessary to show “nonunique” for seq2.

 

I don’t recall having seen something about that in existing issues (sorry if I missed it). I’ll raise an issue for that.

 

Currently, the signature of CollectionFunctions::removeAll is:


removeAll<T> (inout seq: T[*] sequence, in element: T)


According to the associated description, it should probably be (taking into account issue 16426 which requires a return parameter):


removeAll<T> (inout seq1: T[*] sequence, in seq2:T[*] sequence) : T[*] sequence

And the description should also be corrected to read “Remove all elements of seq2 from seq1” (“from” instead of “to”).

The signature of replaceOne is :
replaceOne<T> (in seq: T[*] sequence, in element: T, in newElement: T): T[*] sequence
 
The direction of parameter “seq” should probably be “inout”.

The Alf standard says
"A return statement may only be used within the definition of a behavior that has a return parameter."
We think it must be allowed to always use a return statement. If the context behavior has no return parameter then no expression should be provided in the return statement.

Subject: Errors in Subclause 8.2

Subclause: 8.2 Qualified Names

 

·         In the example at the end of Subclause 8.2 Qualified Names it says “The standard library class Map has two template parameters, K and V.” Actually, the template parameters are “Key” and “Value”.

 

·         The references to UML specification subclauses in Subclause 8.2 are all off by one (e.g., 7.3.34 instead of 7.3.35 for Namespace) for UML 2.4.

Subject: Error in Data Value Creation Expression

Subclause: 8.3.12 Instance Creation Expressions

 

In the second paragraph under “Data Value Creation Expression” in Subclause 8.3.12 Instance Creation Expressions, it says “Each argument expression must be to the corresponding attribute…”. This should be “Each argument expression must be assignable to the corresponding attribute…”.

Subject: SequenceExpressionList::element should be ordered

Subclauses: 8.3.15 Sequence Construction Expressions, 13.1 Overview

 

Since a SequenceExpressionList represents an ordered list of expressions, clearly SequenceExpressionList::element should be ordered.

Subject: Error in bit string conversion

Subclause: 8.8 Assignment Expressions

 

In Subclause 8.8 Assignment Expressions, under “Assignability”, the function referenced for bit string conversion should be ToBitString, not ToInteger.

Subject: @determined should be @determinate

Subclauses: 9.8 if Statement, 9.9 switch Statement, 14.2.13 IfStatement, 14.2.22 SwitchStatement

 

The @determined annotation on if and switch statements should be @determinate, to correspond to the ConditionalNode attribute isDeterminate.

Subject: Inconsistency on being constructorless 

Subclause: 10.5.3.1 Constructors

 

In Subclause 10.5.3.1 it says that the mapping of default constructors “means that the instantiation of a class defined using Alf textual notation is never ‘constructorless’ as defined in Subclause 8.3.12”. However, later in the same subclause it says “If a class has an explicit constructor definition, then the default constructor is no longer available, even if the defined constructor has a different name than the default constructor.” But if no default constructor is available, and there is no explicit constructor with the name of the class and no arguments, then a constructorless instantiation is possible.

Subject: AssignmentExpression as a data value update

Subclause: 13.2.2 AssignmentExpression, 

 

·         An assignment expression should only be allowed to be a data value update if its left hand side is a feature reference whose primary expression is a local name or parameter name.

 

·         The derivation of the assignment for an assignment expression needs to account for the cases of a data value update and an indexed left hand side.

 

Subject: Error in AssignmentExpression constraints

Subclause: 13.2.2 AssignmentExpression

 

·         In Subclause 13.2.1 AssignmentExpression, the constraint assignmentExpressionSimpleAssignmentTypeConformance should require the type of the right-hand side to conform to the type of the left-hand side, not the other way around.

 

·         The type and multiplicity bounds of a compound AssignmentExpression should be those of the left-hand side, not the right-hand side.

Subject: Constructor in a BehaviorInvocationExpression

Subclause: 13.2.3 BehaviorInvocationExpression

 

In Subclause 13.2.17, FeatureInvocationExpression contains the constraint featureInvocationExpressionAlternativeConstructor, which constrains the placement of an alternative constructor invocation within the method of a constructor operation. However, the target name of a BehaviorInvocationExpression may also disambiguate to a feature reference to a constructor. If such an invocation is within the method of a constructor operation, then it also needs to be similarly constrained as an alternative constructor invocation (perhaps by moving featureInvocationAlternativeConstructor constraint needs to be moved to the InvocationExpression superclass).

Subject: Referent of a signal send

Subclauses: 13.2.3 BehaviorInvocationExpression, 13.2.17 FeatureInvocationExpression

 

The description of the InvocationExpression::referent property in Subclause 13.2.23 is “The behavior, operation or signal being invoked.” The featureInvocationExpressionReferentDerivation in Subclause 13.2.17 derives this property as the referent of the feature of the FeatureInvocationExpression. The behaviorInvocationExpressionReferentDerivation in Subclause 13.2.3 has derives the referent similarly, in the case that the target name of a BehaviorInvocationExpression disambiguates to a feature reference. However, for a signal send, the feature being referenced will actually be a reception for the signal, not the signal itself. The derivations in Subclauses 13.2.3 and 13.2.17 should be revised to account for this.

 

Subject: Indexed feature left hand sides

Subclauses: 13.2.18 FeatureLeftHandSide, 13.2.35 NameLeftHandSide

 

In a FeatureLeftHandSide, if the left-hand side has an index, then the referenced feature must be a sequence (simply being ordered is not enough for the “replace” semantics of indexed assignment). Since a similar constraint is required for a NameLeftHandSide with an index, if the name 

disambiguates to a feature, the constraint is probably best handled in a unified way in the LeftHandSide superclass.

Subject: InstanceCreationExpression class must not be abstract

Subclause: 13.2.22 InstranceCreationExpression

 

In Subclause 13.2.22 InstanceCreationExpression there should be a constraint that the class of a constructor operation, or the referent if it is a class or data type, must not be abstract. In the case in which this constraint would be violated, but there is an associated Impl class constructor per Subclause 8.3.12, the referent should be the Impl constructor

Subject: Assigned name must not be template binding

Subclause: 13.2.35 NameLeftHandSide

 

In Subclause 13.2.35 NameLeftHandSide, there needs to be a constraint that the name is not a template binding.

 

Subject: Derivation of SequenceOperationExpression::isCollectionConversion

Subclause: 13.2.50 SequenceOperationExpression

 

In Subclause 13.2.50 SequenceOperationExpression, the derivation for isCollectionConversion should include the requirement that the multiplicity is upper bound is 1.

Subject: Assignment of out parameters in if and switch statements

Subclauses: 14.2.13 ifStatement, 14.2.20 SwitchStatement

 

According to Subclauses 9.8 and 9.9, it is not permitted to define a new local name in an if statement without an else clause or a switch statement without a default clause. The ifStatementAssignmentsAfter and switchStatementAssignments constraints in Subclauses 14.2.13 and 14.2.22 attempt to enforce this by requiring that the assignments after such if or switch statements be the same as those before the statement. However, this constraint is too strong. An out parameter does not have an assign source before it is first assignment, yet it is already defined as a local name. Therefore, the constraints should be loosened to allow an if statement without an else clause or a switch statement without a default clause to contain the first assignment of an out parameter.

Subject: Classifier behavior required for an active class

Subclause: 15.2.1 ActiveClassDefinition

 

A non-abstract active class must have a classifier behavior, because this is required by StartObjectBehaviorAction

Subject: Inherited abstract operations

Subclauses: 15.2.4 ClassDefinition, 15.2.16 OperationDefinition

 

There is currently a constraint for an OperationDefinition that it must owned by a non-abstract class. This isn’t strong enough, because it doesn’t prevent a non-abstract class from inheriting an abstract operation. Instead, there should be a constraint on ClassDefinition that all member operations (owned or inherited) are not abstract.