Issue 10488: Sequence diagrams for Introspection should be added                                                                                                                                                     (rtc-ftf)
Source: Technologic Arts (Mr. Takeshi Sakamoto, tsakamoto@tech-arts.co.jp)
Nature: Uncategorized Issue
Severity: 
Summary: ource: Technologic Arts (Takeshi Sakamoto, [[MailTo(tsakamoto AT SPAMFREE tech-arts DOT co DOT jp)]])

Severity: Supporting Text

Disposition: Resolution Proposed

Summary

Just like RTC, I think it is difficult to understand behavior. I think it would be better that following sequence diagram is added.

Proposed Resolution

[attachment:introspection-connect-sequence.png] [[BR]] Connect

[attachment:introspection-disconnect-sequence.png] [[BR]] Disconnect

Discussion

Revised Text
Resolution: Add diagrams as described below.
Revised Text: ·	Add the following operations to the depiction of PortService (This interface was renamed by the resolution to issue10487.) in Figure 7.16, Introspection interface, in section 7.4.2, Stereotypes and Interfaces.
+ notify_connect(ConnectorProfile) : ReturnCode_t
+ notify_disconnect(UniqueIdentifier) : ReturnCode_t
·	Add the following rows to the operations table in the PortService section (renamed by the resolution to issue 10487), 7.4.2.3. The new rows should be inserted last.
notify_connect		ReturnCode_t
	inout connector_profile	ConnectorProfile
notify_disconnect		ReturnCode_t
	connector_id	UniqueIdentifier
·	In section 7.4.2.3.4 connect, Semantics section is replaced with the following section:
Semantics
A ConnectorProfile has a sequence of port references. This port invokes the notify_connect operation of one of the ports included in the sequence. It follows that the notification of connection is propagated by the notify_connect operation with ConnectorProfile. This operation returns ConnectorProfile return value and returns ReturnCode_t as return codes.
 
Figure < number > - PortService::connect Example
·	Replace the contents of section 7.4.2.3.5, disconnect, with the following:
Description
This operation destroys the connection between this port and its peer ports using the ID that was given when the connection was established.
Semantics
This port invokes the notify_disconnect operation of one of the ports included in the sequence of the ConnectorProfile stored when the connection was established. The notification of disconnection is propagated by the notify_disconnect operation.
 
Figure < number > - PortService::disconnect Example
·	Add the following sections after section 7.4.2.3.6, disconnect_all:
7.4.2.3.7 notify_connect
Description
This operation notifies this PortService of the connection between its corresponding port and the other ports and propagates the given ConnectionProfile.
Semantics
A ConnectorProfile has a sequence of port references. This PortService stores the ConnectorProfile and invokes the notify_connect operation of the next PortService in the sequence. As ports are added to the connector, PortService references are added to the ConnectorProfile and provided to the caller. In this way, notification of connection is propagated with the ConnectorProfile.
7.4.2.3.8 notify_disconnect
Description
This operation notifies a PortService of a disconnection between its corresponding port and the other ports. The disconnected connector is identified by the given ID, which was given when the connection was established.
Semantics
This port invokes the notify_disconnect operation of the next PortService in the sequence of the ConnectorProfile that was stored when the connection was established. As ports are disconnected, PortService references are removed from the ConnectorProfile. In this way, the notification of disconnection is propagated by the notify_disconnect operation.
·	Update the PortService::connect operation in the IDL in RTC.idl and Annex A:
interface PortService : SDOPackage ::SDOService {
    // …
    ReturnCode_t connect(inout ConnectorProfile connector_profile);
    //
};
·	Add the following operations to the IDL in RTC.idl and Annex A:
interface PortService : SDOPackage ::SDOService {
    // … disconnect_all and other operations
    ReturnCode_t notify_connect(inout ConnectorProfile connector_profile);
    ReturnCode_t notify_disconnect(in UniqueIdentifier connector_id);
};



Actions taken:
December 5, 2006: received issue
January 15, 2008: closed issue
Discussion: 

End of Annotations:=====
MG ISSUE 10488: Sequence diagrams for Introspection should be added

Source: Technologic Arts (Takeshi Sakamoto, [[MailTo(tsakamoto AT SPAMFREE tech-arts DOT co DOT jp)]])

Severity: Supporting Text

Disposition: Resolution Proposed

Summary

Just like RTC, I think it is difficult to understand behavior. I think it would be better that following sequence diagram is added.

Proposed Resolution

[attachment:introspection-connect-sequence.png] [[BR]] Connect

[attachment:introspection-disconnect-sequence.png] [[BR]] Disconnect

Discussion

Revised Text