Issue 13072: AMS_RTSWIndication unpractical/incorrect definition (amsm-ftf)
Source: THALES (Mr. Willy Boenink, willy.boenink(at)nl.thalesgroup.com)
Nature: Enhancement
Severity: Significant
Summary: AMS_RTSWIndication unpractical/incorrect definition The attribute ElementCase equals the discriminant of the union Element and should be removed. As an preferred solution, the union can be replaced by just one string indicating the referenced topic, the union cases only differentiate in naming of the attribute, not the type. This allows setting a query on this field. The keylist is also incorrect, a union may not be part of the keylist. AMS_RTSW should also not be part of the keylist because an Element can have only one state at a time. 

Resolution: Replace the union Element with a struct as proposed. Modify the keylist as proposed as well.
Revised Text: In section 11.1.6 ("Mapping"), in page 281 and 282, replace the following text:
	//
	union AMS_RTSWIndication_Element switch (AMS_RTSWIndication_Case) {
		case AMS_ESE_IndicationCase:
			// full name of elements of AMS_ExecutableSoftwareElement
			string ESE;
		case AMS_Application_IndicationCase:
			// full name of elements of AMS_Application
			string Application;
		case AMS_System_IndicationCase:
			// full name of elements of AMS_SoftwareSystem
			string System;
		case AMS_LB_IndicationCase:
			// full name of elements of AMS_LoadBalancingGroup
			string LB;
		case AMS_FT_IndicationCase:
			// full name of elements of AMS_RedundancyGroup
			string RG;
	};
	struct AMS_RTSWIndication {
		//
		AMS_RTSWIndication_Case ElementCase;
		AMS_RTSWIndication_Element Element;
		//
		AMS_RTSoftwareStatus AMS_RTSW;
		//
		string IndicationTime;
	};
#pragma keylist AMS_RTSWIndication Element,AMS_RTSW
With the following:
	//	
	struct AMS_RTSWIndication {
		//
		AMS_RTSWIndication_Case ElementCase;
		// full name of elements of AMS_ExecutableSoftwareElement
		// full name of elements of AMS_Application
		// full name of elements of AMS_SoftwareSystem
		// full name of elements of AMS_LoadBalancingGroup
		// full name of elements of AMS_RedundancyGroup
		string Element;
		//
		AMS_RTSoftwareStatus AMS_RTSW;
		//
		string IndicationTime;
	};
#pragma keylist AMS_RTSWIndication Element

Actions taken:
November 12, 2008: received issue
November 12, 2008: received issue
July 23, 2009: closed issue
Discussion: 

End of Annotations:=====

m: webmaster@omg.org
Date: 12 Nov 2008 08:14:17 -0500
To: <issues@omg.org>
Subject: Issue/Bug Report



--------------------------------------------------------------------------------

Name: Willy Boenink
Company: Thales Nederland
mailFrom: willy.boenink@nl.thalesgroup.com
Notification: No
Specification: AMSM
Section: 11.1.6
FormalNumber: dtc/2008-02-02
Version: Beta 2
RevisionDate: 02/02/2008
Page: 282
Nature: Enhancement
Severity: Significant
HTTP User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9) Gecko/2008051206 Firefox/3.0
Description
AMS_RTSWIndication unpractical/incorrect definition The attribute ElementCase equals the discriminant of the union Element and should be removed. As an preferred solution, the union can be replaced by just one string indicating the referenced topic, the union cases only differentiate in naming of the attribute, not the type. This allows setting a query on this field. The keylist is also incorrect, a union may not be part of the keylist. AMS_RTSW should also not be part of the keylist because an Element can have only one state at a time.