Issue 17066: Useless ReaderQuery on DataReader read/take (dds-psm-cxx-ftf) Source: PrismTech (Dr. Angelo Corsaro, PhD., angelo.corsaro(at)prismtech.com) Nature: Enhancement Severity: Minor Summary: The ReaderQuery class bundles together the read-state as well as potential read conditions. However the read-condition is not always present. This leads to code that needs to check all the time wether something is set or not, which is not only very elegant/efficient but it is also error prone Resolution --------------- Remove the ReaderQuery and let the read API deal, through proper operations overloads, with ReadState and potential ReadConditions. This way it will always be clear if a read/take is with a condition or not both for the client code and the DDS implementor. Resolution: Revised Text: Actions taken: January 26, 2012: received issue Discussion: End of Annotations:===== m: Angelo Corsaro Subject: Fwd: ReaderQuery makes the read API error-prone To: Juergen Boldt Begin forwarded message: From: Angelo Corsaro Subject: ReaderQuery makes the read API error-prone Date: 25 January, 2012 12:59:53 GMT+01:00 To: issues@omg.org, dds-psm-cxx-ftf@omg.org Cc: Juergen Boldt Name: Angelo Corsaro Employer: PrismTech eMail: angelo@icorsaro.net Specification: ISO C++ DDS PSM Version: Beta 1 Title: Assignment Rule for Container Types Nature: Robustness/Performance Severity: Minor Description --------------- The ReaderQuery class bundles together the read-state as well as potential read conditions. However the read-condition is not always present. This leads to code that needs to check all the time wether something is set or not, which is not only very elegant/efficient but it is also error prone Resolution --------------- Remove the ReaderQuery and let the read API deal, through proper operations overloads, with ReadState and potential ReadConditions. This way it will always be clear if a read/take is with a condition or not both for the client code and the DDS implementor. -- Angelo Corsaro, PhD Chief Technology Officer PrismTech 4 rue Angiboust | 91460 Marcoussis | France T +33 1 69 01 53 54 | M +33 6 42 30 75 65 ------------------------------------------------------------------------------------------------------------------ http://icorsaro.net | http://twitter.com/acorsaro | http://slideshare.net/angelo.corsaro ------------------------------------------------------------------------------------------------------------------ -- Angelo Corsaro, PhD Chief Technology Officer PrismTech 4 rue Angiboust | 91460 Marcoussis | France T +33 1 69 01 53 54 | M +33 6 42 30 75 65 ------------------------------------------------------------------------------------------------------------------ http://icorsaro.net | http://twitter.com/acorsaro | http://slideshare.net/angelo.corsaro ------------------------------------------------------------------------------------------------------------------