Issue 18627: API correction required to src/hpp/dds/core/policy/TCorePolicy.hpp (dds-psm-cxx-rtf) Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com) Nature: Uncategorized Issue Severity: Summary: Compilation fixes and corrections to API documentation comments required. Incorrect default reliability duration (infinite). Should be 100 milliseconds per table in section "7.1.3 Supported QoS" (formal 07-01-01) _Suggested resolution_: diff --git a/src/hpp/dds/core/policy/TCorePolicy.hpp b/src/hpp/dds/core/policy/TCorePolicy.hpp index 382e521..1313b32 100644 --- a/src/hpp/dds/core/policy/TCorePolicy.hpp +++ b/src/hpp/dds/core/policy/TCorePolicy.hpp @@ -47,7 +47,7 @@ namespace dds { namespace core { namespace policy { /** * Create a <code>UserData</code> instance with an empty user data. */ - TUserData() : dds::core::Value<D>(); + TUserData(); /** * Create a <code>UserData</code> instance. @@ -56,7 +56,7 @@ namespace dds { namespace core { namespace policy { */ explicit TUserData(const dds::core::ByteSeq& seq); - //@TODO Implement + /** @todo Implement this */ TUserData(const uint8_t* value_begin, const uint8_t* value_end); TUserData(const TUserData& other); @@ -102,16 +102,16 @@ namespace dds { namespace core { namespace policy { class TGroupData : public dds::core::Value<D> { public: /** - * Create a <code>GroupData<code> instance. + * Create a <code>GroupData</code> instance. */ - TGroupData() : dds::core::Value<D>(); + TGroupData(); /** - * Create a <code>GroupData<code> instance. + * Create a <code>GroupData</code> instance. * * @param seq the group data value */ - explicit TGroupData(const dds::core::ByteSeq& seq) : dds::core::Value<D>(seq); + explicit TGroupData(const dds::core::ByteSeq& seq); TGroupData(const TGroupData& other); @@ -160,7 +160,7 @@ namespace dds { namespace core { namespace policy { template <typename D> class TTopicData : public dds::core::Value<D> { public: - TTopicData() : dds::core::Value<D>(); + TTopicData(); explicit TTopicData(const dds::core::ByteSeq& seq); @@ -219,7 +219,7 @@ namespace dds { namespace core { namespace policy { template <typename D> class TEntityFactory : public dds::core::Value<D> { public: - TEntityFactory() :dds::core::Value<D>(true); + TEntityFactory(); explicit TEntityFactory(bool the_auto_enable); TEntityFactory(const TEntityFactory& other); @@ -255,7 +255,7 @@ namespace dds { namespace core { namespace policy { public: explicit TTransportPriority(int32_t prio); - TTransportPriority() : dds::core::Value<D>(0); + TTransportPriority(); TTransportPriority(const TTransportPriority& other); @@ -554,7 +554,7 @@ namespace dds { namespace core { namespace policy { const dds::core::Duration max_blocking_time() const; public: - static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration::infinite()); + static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration(0, 100000000)); static TReliability BestEffort(); }; Resolution: Revised Text: Actions taken: April 9, 2013: received issue Discussion: End of Annotations:===== ogle-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=7qPdTwjFtpMoFhltrzknxUutosZpB0EhwG6UdXn3tlE=; b=O+oRCun+ZdieIQVpkHy4yqptv/Krez6NLdXq02Vyp7HtBz3G9zlG2Egh9AEEDsfPSn TGh6ja3D8EFxT16q3Dc5eWhUQeug66YFm95bxXf0T6H30gIEgBvJHUTwOZwbxkdKfpae 5B7qjW090pl0nUEwlXz24yHPGipUth7ZRoyux+3H4Dnbf7Ter8zOFzDX8acE3XNlQxyw mBAB3xiJlxwx4wH29gFv+GCho+TnRyY//LNlJqDSXBknK7YwRXCKUirBzUxzCnjhKa1g ezMMGnO52wO82qyekxgyf7/VHodx+M5lJMebGGU/Z9raHwqI5aaCxzFnWxa6J0N3j4xA CRlA== X-Received: by 10.180.185.239 with SMTP id ff15mr19799631wic.2.1365513194547; Tue, 09 Apr 2013 06:13:14 -0700 (PDT) Date: Tue, 09 Apr 2013 14:13:03 +0100 From: Simon McQueen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 To: issues@omg.org Subject: API correction required to src/hpp/dds/core/policy/TCorePolicy.hpp X-Gm-Message-State: ALoCoQnELwtcJPpu7Z1xHaaBEsBQktzQuhyjdgjQTfeAD1+gYAMNUJGg9I5qn4nqHt7oFO76d6j5 X-Virus-Scanned: amavisd-new at omg.org X-Brightmail-Tracker: AAAAAA== X-Brightmail-Tracker: AAAAAA== Name: Simon McQueen Employer: PrismTech Specification: DDS CXX PSM RTF FormalNumber: ptc/12-10-03 Nature: Revision _Issues_: Compilation fixes and corrections to API documentation comments required. Incorrect default reliability duration (infinite). Should be 100 milliseconds per table in section "7.1.3 Supported QoS" (formal 07-01-01) _Suggested resolution_: diff --git a/src/hpp/dds/core/policy/TCorePolicy.hpp b/src/hpp/dds/core/policy/TCorePolicy.hpp index 382e521..1313b32 100644 --- a/src/hpp/dds/core/policy/TCorePolicy.hpp +++ b/src/hpp/dds/core/policy/TCorePolicy.hpp @@ -47,7 +47,7 @@ namespace dds { namespace core { namespace policy { /** * Create a UserData instance with an empty user data. */ - TUserData() : dds::core::Value(); + TUserData(); /** * Create a UserData instance. @@ -56,7 +56,7 @@ namespace dds { namespace core { namespace policy { */ explicit TUserData(const dds::core::ByteSeq& seq); - //@TODO Implement + /** @todo Implement this */ TUserData(const uint8_t* value_begin, const uint8_t* value_end); TUserData(const TUserData& other); @@ -102,16 +102,16 @@ namespace dds { namespace core { namespace policy { class TGroupData : public dds::core::Value { public: /** - * Create a GroupData instance. + * Create a GroupData instance. */ - TGroupData() : dds::core::Value(); + TGroupData(); /** - * Create a GroupData instance. + * Create a GroupData instance. * * @param seq the group data value */ - explicit TGroupData(const dds::core::ByteSeq& seq) : dds::core::Value(seq); + explicit TGroupData(const dds::core::ByteSeq& seq); TGroupData(const TGroupData& other); @@ -160,7 +160,7 @@ namespace dds { namespace core { namespace policy { template class TTopicData : public dds::core::Value { public: - TTopicData() : dds::core::Value(); + TTopicData(); explicit TTopicData(const dds::core::ByteSeq& seq); @@ -219,7 +219,7 @@ namespace dds { namespace core { namespace policy { template class TEntityFactory : public dds::core::Value { public: - TEntityFactory() :dds::core::Value(true); + TEntityFactory(); explicit TEntityFactory(bool the_auto_enable); TEntityFactory(const TEntityFactory& other); @@ -255,7 +255,7 @@ namespace dds { namespace core { namespace policy { public: explicit TTransportPriority(int32_t prio); - TTransportPriority() : dds::core::Value(0); + TTransportPriority(); TTransportPriority(const TTransportPriority& other); @@ -554,7 +554,7 @@ namespace dds { namespace core { namespace policy { const dds::core::Duration max_blocking_time() const; public: - static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration::infinite()); + static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration(0, 100000000)); static TReliability BestEffort(); };