Issue 18643: API correction required to src/hpp/dds/sub/AnyDataReaderListener.hpp (dds-psm-cxx-rtf) Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com) Nature: Uncategorized Issue Severity: Summary: Vestigial implementation code needs removing to be consistent with other No-op listener declarations. Missing headers required to fix compilation. _Suggested resolution_: diff --git a/src/hpp/dds/sub/AnyDataReaderListener.hpp b/src/hpp/dds/sub/AnyDataReaderListener.hpp index 4646bfd..aabd71a 100644 --- a/src/hpp/dds/sub/AnyDataReaderListener.hpp +++ b/src/hpp/dds/sub/AnyDataReaderListener.hpp @@ -19,6 +19,8 @@ * limitations under the License. */ +#include <dds/core/refmacros.hpp> +#include <dds/core/status/Status.hpp> namespace dds { namespace sub { @@ -59,37 +61,36 @@ namespace dds { namespace sub { const dds::core::status::SampleLostStatus& status) = 0; }; - class NoOpAnyDataReaderListener : public virtual AnyDataReaderListener { public: - virtual ~NoOpAnyDataReaderListener() { } + virtual ~NoOpAnyDataReaderListener(); public: virtual void on_requested_deadline_missed( AnyDataReader& the_reader, - const dds::core::status::RequestedDeadlineMissedStatus& status) { } + const dds::core::status::RequestedDeadlineMissedStatus& status); virtual void on_requested_incompatible_qos( AnyDataReader& the_reader, - const dds::core::status::RequestedIncompatibleQosStatus& status) { } + const dds::core::status::RequestedIncompatibleQosStatus& status); virtual void on_sample_rejected( AnyDataReader& the_reader, - const dds::core::status::SampleRejectedStatus& status) { } + const dds::core::status::SampleRejectedStatus& status); virtual void on_liveliness_changed( AnyDataReader& the_reader, - const dds::core::status::LivelinessChangedStatus& status) { } + const dds::core::status::LivelinessChangedStatus& status); - virtual void on_data_available(AnyDataReader& the_reader) { } + virtual void on_data_available(AnyDataReader& the_reader); virtual void on_subscription_matched( AnyDataReader& the_reader, - const dds::core::status::SubscriptionMatchedStatus& status) { } + const dds::core::status::SubscriptionMatchedStatus& status); virtual void on_sample_lost( AnyDataReader& the_reader, - const dds::core::status::SampleLostStatus& status) { } + const dds::core::status::SampleLostStatus& status); }; } } Resolution: Revised Text: Actions taken: April 9, 2013: received issue Discussion: End of Annotations:===== ogle-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=+E6ilhNpMJp8Q7Pm9fShpQm7kQhjGkJT7UuYq6aTHWE=; b=ntS6u5TX1U432RjHkVPquj52t1Oqj8Iwp5pZrdg6qxfCEbxC12NxYymHcX4oKy0H3y Hv4Df3jCGTDXCU6ImXm+hZzoQvuc4sd53QOxtODUMRjaSui0ilELoFnRGANYbQ27RP98 +q6wAtQ+qNe8pU2S3xoIGT78yLsQf/T3edosVFF0hNYBKEN+w5LyhhjnsPsBSAJORkWo 0y7COtwRU7quZQ9A2XFPNLvyLErhk1MKj/P1zONWx8vNz6iyPtopzoP3orHk54JZpXYl K2nE7Fkb8cWbKgt6RSvHd5S16xUv9M7lpBp7dezFn9E9pARo2WgngXFyIpYr63heCJEF MLyg== X-Received: by 10.180.91.106 with SMTP id cd10mr20349660wib.6.1365518540073; Tue, 09 Apr 2013 07:42:20 -0700 (PDT) Date: Tue, 09 Apr 2013 15:42:08 +0100 From: Simon McQueen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 To: issues@omg.org Subject: API correction required to src/hpp/dds/sub/AnyDataReaderListener.hpp X-Gm-Message-State: ALoCoQk8q4A2Zxub1KLzBhN9BGAn2KzPrkAH3fM7RUsZ4iDkUVIS5YxwFR5jAFM/Ej2XrH2QW6na X-Virus-Scanned: amavisd-new at omg.org X-Brightmail-Tracker: AAAAAR15SuM= X-Brightmail-Tracker: AAAAAA== Name: Simon McQueen Employer: PrismTech Specification: DDS CXX PSM RTF FormalNumber: ptc/12-10-03 Nature: Revision _Issues_: Vestigial implementation code needs removing to be consistent with other No-op listener declarations. Missing headers required to fix compilation. _Suggested resolution_: diff --git a/src/hpp/dds/sub/AnyDataReaderListener.hpp b/src/hpp/dds/sub/AnyDataReaderListener.hpp index 4646bfd..aabd71a 100644 --- a/src/hpp/dds/sub/AnyDataReaderListener.hpp +++ b/src/hpp/dds/sub/AnyDataReaderListener.hpp @@ -19,6 +19,8 @@ * limitations under the License. */ +#include +#include namespace dds { namespace sub { @@ -59,37 +61,36 @@ namespace dds { namespace sub { const dds::core::status::SampleLostStatus& status) = 0; }; - class NoOpAnyDataReaderListener : public virtual AnyDataReaderListener { public: - virtual ~NoOpAnyDataReaderListener() { } + virtual ~NoOpAnyDataReaderListener(); public: virtual void on_requested_deadline_missed( AnyDataReader& the_reader, - const dds::core::status::RequestedDeadlineMissedStatus& status) { } + const dds::core::status::RequestedDeadlineMissedStatus& status); virtual void on_requested_incompatible_qos( AnyDataReader& the_reader, - const dds::core::status::RequestedIncompatibleQosStatus& status) { } + const dds::core::status::RequestedIncompatibleQosStatus& status); virtual void on_sample_rejected( AnyDataReader& the_reader, - const dds::core::status::SampleRejectedStatus& status) { } + const dds::core::status::SampleRejectedStatus& status); virtual void on_liveliness_changed( AnyDataReader& the_reader, - const dds::core::status::LivelinessChangedStatus& status) { } + const dds::core::status::LivelinessChangedStatus& status); - virtual void on_data_available(AnyDataReader& the_reader) { } + virtual void on_data_available(AnyDataReader& the_reader); virtual void on_subscription_matched( AnyDataReader& the_reader, - const dds::core::status::SubscriptionMatchedStatus& status) { } + const dds::core::status::SubscriptionMatchedStatus& status); virtual void on_sample_lost( AnyDataReader& the_reader, - const dds::core::status::SampleLostStatus& status) { } + const dds::core::status::SampleLostStatus& status); }; } }