Issue 18645: API correction required to src/hpp/dds/sub/DataReaderListener.hpp (dds-psm-cxx-rtf)
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Uncategorized Issue
Severity: 
Summary: Code needs compilation fixes.


_Suggested resolution_:


diff --git a/src/hpp/dds/sub/DataReaderListener.hpp b/src/hpp/dds/sub/DataReaderListener.hpp
index 17c620e..70b2777 100644
--- a/src/hpp/dds/sub/DataReaderListener.hpp
+++ b/src/hpp/dds/sub/DataReaderListener.hpp
@@ -32,10 +32,10 @@ namespace dds { namespace sub {
 template <typename T>
 class dds::sub::DataReaderListener {
 public:
-  typedef ::dds::core::smart_ptr_traits<DataReaderListener>::ref_type ref_type;
+  typedef typename ::dds::core::smart_ptr_traits<DataReaderListener>::ref_type ref_type;


 public:
-  virtual ~DataReaderListener();
+  virtual ~DataReaderListener() = 0;


 public:
   virtual void on_requested_deadline_missed(
@@ -69,7 +69,7 @@ public:
 template <typename T>
 class dds::sub::NoOpDataReaderListener : public virtual DataReaderListener<T> {
 public:
-  typedef ::dds::core::smart_ptr_traits<NoOpDataReaderListener>::ref_type ref_type;
+  typedef typename ::dds::core::smart_ptr_traits<NoOpDataReaderListener>::ref_type ref_type;


 public:
   virtual ~NoOpDataReaderListener();
Resolution: 
Revised Text: 
Actions taken:
April 9, 2013: received issue
Discussion: 

End of Annotations:=====

ogle-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=x-received:message-id:date:from:user-agent:mime-version:to:subject
         :content-type:content-transfer-encoding:x-gm-message-state;
        bh=0lzhI5xn3M4lzZKr4G83oq6wWn4rItTqUQd+WW/hTCY=;
        b=BF1aOQV1sQ554g+/RLKXf73wPoHCBV01DB3hdJ4oCLc2bozlq2RUuzfGpSe7cJ/F/t
         grnQ8DI20Wv9vrBwyIq7aqA0HclHBhMvNAukfJJNoxqWWDwe++4Q0yvVBTy/R7obJr4w
         H6RHiisM52SEe0+Ng9LpSd+yQ9IpOMMwQ0g6owgERXuHShTShVUMX0DC9VgY5wlHkVVn
         SKCVGLSREJODX3nhZ3fHvIhrJhaotfeS5kjP59+OgvFP7VPj253nEKi2fr8kXXlUK1Tu
         Pjc304rKSTqPh7ba1s2PGcG84vwj6Pn7YCLzLl1I/1ktimgCEF/8dbUH53atmVtGLjoh
         VJgA==
X-Received: by 10.194.119.33 with SMTP id kr1mr39292695wjb.36.1365520752426;
        Tue, 09 Apr 2013 08:19:12 -0700 (PDT)
Date: Tue, 09 Apr 2013 16:19:00 +0100
From: Simon McQueen <sm@prismtech.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4
To: issues@omg.org
Subject: API correction required to src/hpp/dds/sub/DataReaderListener.hpp
X-Gm-Message-State: ALoCoQm/0Rx6YRLUO18V9h6EAzrKsjSMMlbaB7BySV8I6RhqafWdw6F0Mk5RD/exLPw1z+5JCnsl
X-Virus-Scanned: amavisd-new at omg.org
X-Brightmail-Tracker: AAAAAR15SuM=
X-Brightmail-Tracker: AAAAAA==


Name:            Simon McQueen
Employer:        PrismTech
Specification:   DDS CXX PSM RTF
FormalNumber:    ptc/12-10-03
Nature:          Revision


_Issues_:


Code needs compilation fixes.


_Suggested resolution_:


diff --git a/src/hpp/dds/sub/DataReaderListener.hpp b/src/hpp/dds/sub/DataReaderListener.hpp
index 17c620e..70b2777 100644
--- a/src/hpp/dds/sub/DataReaderListener.hpp
+++ b/src/hpp/dds/sub/DataReaderListener.hpp
@@ -32,10 +32,10 @@ namespace dds { namespace sub {
 template <typename T>
 class dds::sub::DataReaderListener {
 public:
-  typedef ::dds::core::smart_ptr_traits<DataReaderListener>::ref_type ref_type;
+  typedef typename ::dds::core::smart_ptr_traits<DataReaderListener>::ref_type ref_type;


 public:
-  virtual ~DataReaderListener();
+  virtual ~DataReaderListener() = 0;


 public:
   virtual void on_requested_deadline_missed(
@@ -69,7 +69,7 @@ public:
 template <typename T>
 class dds::sub::NoOpDataReaderListener : public virtual DataReaderListener<T> {
 public:
-  typedef ::dds::core::smart_ptr_traits<NoOpDataReaderListener>::ref_type ref_type;
+  typedef typename ::dds::core::smart_ptr_traits<NoOpDataReaderListener>::ref_type ref_type;


 public:
   virtual ~NoOpDataReaderListener();