Issue 18649: API correction required to src/hpp/dds/sub/TDataReader.hpp (dds-psm-cxx-rtf)
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Uncategorized Issue
Severity: 
Summary: Duplicate function definition to remove.


Missing header required to fix compilation.


Correct comments.


_Suggested resolution_:


diff --git a/src/hpp/dds/sub/TDataReader.hpp b/src/hpp/dds/sub/TDataReader.hpp
index e10705c..ca592bb 100644
--- a/src/hpp/dds/sub/TDataReader.hpp
+++ b/src/hpp/dds/sub/TDataReader.hpp
@@ -23,6 +23,7 @@
 #include <dds/topic/ContentFilteredTopic.hpp>
 #include <dds/topic/TopicInstance.hpp>
 #include <dds/sub/LoanedSamples.hpp>
+#include <dds/sub/Subscriber.hpp>


 namespace dds {
   namespace sub {
@@ -56,7 +57,6 @@ public:
     Selector(DataReader& dr);


     Selector& instance(const dds::core::InstanceHandle& h);
-    Selector& instance(const dds::core::InstanceHandle& h);
     Selector& state(const dds::sub::status::DataState& s);
     Selector& content(const dds::sub::Query& query);
     Selector& max_samples(uint32_t n);
@@ -220,7 +220,7 @@ public:


   /**
    * Returns the default read-state (if not changed, it is set to
-   * ReaderState::any()).
+   * DataState::any()).
    */
   const dds::sub::status::DataState& default_filter_state();


@@ -258,7 +258,7 @@ public:
    * Read all samples using the default filter state. The memory used for
    * storing the sample may be loaned by the middleware thus allowing zero
    * copy operations.
-   * Implementation should strike to makethis read implementation
+   * Implementors should strive to make this read implementation
    * exception safe.
    */
   LoanedSamples<T> read();
@@ -267,7 +267,7 @@ public:
    * Take all samples using the default filter state. The memory used for
    * storing the sample may be loaned by the middleware thus allowing zero
    * copy operations.
-   * Implementation should strike to make this read implementation
+   * Implementors should strive to make this take implementation
    * exception safe.
    */
   LoanedSamples<T> take();
Resolution: 
Revised Text: 
Actions taken:
April 9, 2013: received issue
Discussion: 

End of Annotations:=====

ogle-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=x-received:message-id:date:from:user-agent:mime-version:to:subject
         :content-type:content-transfer-encoding:x-gm-message-state;
        bh=WLVP12Ct79gWjiAvId4b8kNIN4Guk17l08XywmT50OY=;
        b=HnSqlkGT+d81avFm4iLVBSB39pgVgRJfYRjrJ+PbD1mbligH9dh0H/OdXSqobBxH7V
         ZQcOG8Gq6eEeN1qIxh/AYK/mUt3DAxIhC0KVloRtWkMd6qpU5SOh24Hi0CDa8irJts4z
         jHH0UV+OaQds+okdsAnlTQOaUgKd1XHFU5cDnuH1Mgx57i/iL9LE8r6uoiCQ2BTddoHu
         y9ya1ysl7kfiqyr2PkQUK5pOGYiTEwpDbzxmkI+uROhab5LTfL44115rgwzBxNegcO2D
         hhCnHztxD+hCuO1lHnd8sJO67FsEw8XpknPVw/1U2vzHPPnFQR0HfUGJnaW5lNZXuAO6
         u0MA==
X-Received: by 10.180.90.41 with SMTP id bt9mr20631197wib.19.1365521922047;
        Tue, 09 Apr 2013 08:38:42 -0700 (PDT)
Date: Tue, 09 Apr 2013 16:38:30 +0100
From: Simon McQueen <sm@prismtech.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4
To: issues@omg.org
Subject: API correction required to src/hpp/dds/sub/TDataReader.hpp
X-Gm-Message-State: ALoCoQnBr52ETDRJvkMSOzLVlJP69l/HJyXO8oZ2m6IUHCQKuyGbhT4r67ZpudHlZX8MLOdQ6EsQ
X-Virus-Scanned: amavisd-new at omg.org
X-Brightmail-Tracker: AAAAAA==
X-Brightmail-Tracker: AAAAAA==


Name:            Simon McQueen
Employer:        PrismTech
Specification:   DDS CXX PSM RTF
FormalNumber:    ptc/12-10-03
Nature:          Revision


_Issues_:


Duplicate function definition to remove.


Missing header required to fix compilation.


Correct comments.


_Suggested resolution_:


diff --git a/src/hpp/dds/sub/TDataReader.hpp b/src/hpp/dds/sub/TDataReader.hpp
index e10705c..ca592bb 100644
--- a/src/hpp/dds/sub/TDataReader.hpp
+++ b/src/hpp/dds/sub/TDataReader.hpp
@@ -23,6 +23,7 @@
 #include <dds/topic/ContentFilteredTopic.hpp>
 #include <dds/topic/TopicInstance.hpp>
 #include <dds/sub/LoanedSamples.hpp>
+#include <dds/sub/Subscriber.hpp>


 namespace dds {
   namespace sub {
@@ -56,7 +57,6 @@ public:
     Selector(DataReader& dr);


     Selector& instance(const dds::core::InstanceHandle& h);
-    Selector& instance(const dds::core::InstanceHandle& h);
     Selector& state(const dds::sub::status::DataState& s);
     Selector& content(const dds::sub::Query& query);
     Selector& max_samples(uint32_t n);
@@ -220,7 +220,7 @@ public:


   /**
    * Returns the default read-state (if not changed, it is set to
-   * ReaderState::any()).
+   * DataState::any()).
    */
   const dds::sub::status::DataState& default_filter_state();


@@ -258,7 +258,7 @@ public:
    * Read all samples using the default filter state. The memory used for
    * storing the sample may be loaned by the middleware thus allowing zero
    * copy operations.
-   * Implementation should strike to makethis read implementation
+   * Implementors should strive to make this read implementation
    * exception safe.
    */
   LoanedSamples<T> read();
@@ -267,7 +267,7 @@ public:
    * Take all samples using the default filter state. The memory used for
    * storing the sample may be loaned by the middleware thus allowing zero
    * copy operations.
-   * Implementation should strike to make this read implementation
+   * Implementors should strive to make this take implementation
    * exception safe.
    */
   LoanedSamples<T> take();