Issues for DDS PSM Cxx v1.1 Revision Task Force

To comment on any of these issues, send email to [email protected]. (Please include the issue number in the Subject: header, thusly: [Issue ###].) To submit a new issue, send email to [email protected].

List of issues (green=resolved, yellow=pending Board vote, red=unresolved)

List options: All ; Open Issues only; or Closed Issues only

Jira Issues

Issue 17063: Condition classes should only be used with WaitSets (dds-psm-cxx-rtf)

Click here for this issue's archive.
Nature: Clarification
Severity: Significant
Summary:

The DataReader API provides methods to read samples with a condition. This condition can be either a ReadCondition or a QueryCondition, and in this case the samples returned are either filtered by the status (ReadCondition) or the content+status (QueryCondition).  The ReadCondition is completely in overlap with the instance/status/view states and its use is really irrelevant when in combination with the DataReader. On the other end the only aspect of the QueryCondition that really matters to a DataReader are the query expression and parameters.       By looking carefully at the API, it seems apparent that the ReadCondition and the QueryCondition really make sense only when used with a WaitSet. On the other end, their use in conjunction of a DataReader is a stretch and breaks the semantics of the "Condition". On principle a condition is used to "wait" for a particular status to be true, yet the DataReader "read" are -- rightfully -- always non-blocking. In addition, the API opens up for gratuitous runtime errors as I could write silly code as follows (in C++):      auto  rc = reader.create_readcondition();  reader2.read(..., rc,...);      This although silly is allowed by the API and on a proper DDS implementation should raise an exception.      The same could happen with a QueryCondition!              Resolution  ---------------  Limit the use of Read/QueryCondition to waitsets and put in place a more robust mechanism to do status and content filtering on a data-reader read.      An example of what could be done is provided below, where I assume that the DataStatus is the former ReaderState:         reader        .filter_status(DataStatus::new_data())        .filter_content(Query("x < 100 AND  y < 100"))        .read();      Equally, one could write (again legal C++ below with little magic under-cover) :         reader        .instance(handle)        .filter_status(DataStatus::new_data())        .filter_content(Query("x < 100 AND  y < 100"))        .read();          Notice that this code, not only  is very declarative and thus shows very clearly the intent of the programmer, but in addition does not allow for the silly mistakes shown above. Further more, it really highlights he role of the Sample/Instance/View status as a "filter" on the status of data.

Resolution:
Revised Text:
Actions taken:
January 26, 2012: received issue

Issue 18445: EntityQos is overly general (dds-psm-cxx-rtf)

Click here for this issue's archive.
Nature: Enhancement
Severity: Significant
Summary:

EntityQos template is a rather overly general way of setting and getting policies. Member template functions generate the code depending upon the policy type. If you pass a wrong type, it eventually ends up showing a link-time error as opposed to a compile-time error. For instance, there is a link-time error in the code below because DataWriterQos has no presentation policy.     dds::pub::qos::DataWriterQos dwqos;  dds::core::policy::Deadline d;  dds::core::policy::Presentation p;  dwqos >> p; /// Linker error here. No compile-time error  dwqos >> d; /// Fine!      Additionally, the dot operator provides no help for syntax completion because the policy function is a member template. Consequently, the end-user might be tempted to use the -> operator, which does provide syntax completion depending upon the implementation of the delegate. As a result, for standard policies -> will be used, which is unintended.      Proposed Resolution:      1. Add template classes DataReaderQos, DataWriterQoS, PublisherQos, SubscriberQos, DomainParticipantQos in the dds namespace.       2. Support non-template member functions for setting and getting respective policies. For instance. dwqos.deadline() and dwqos.deadline(d) should be supported.       3. Define operator << and operator >> outside the QoS class and overload for the respective  policies.       4. The templated verions of policy getters/setters can still be supported. However, I seriously doubt their usefulness. If we decide to keep them, at least I would like to turn the linker error into compiler error using a meta-programming technique described here:     http://cpptruths.googlecode.com/svn/trunk/cpp/entityqos.cpp

Resolution:
Revised Text:
Actions taken:
February 12, 2013: received issue

Issue 18612: API corrections required to src/hpp/dds/core/Exception.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      API requires warning suppression with MS Visual Studio.  MS symbol export macros missing.  Missing constructor.  Incorrect comments.  Some in-line definition remaining in declaration only file.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/Exception.hpp b/src/hpp/dds/core/Exception.hpp  index 84c7c28..22b05ab 100644  --- a/src/hpp/dds/core/Exception.hpp  +++ b/src/hpp/dds/core/Exception.hpp  @@ -23,15 +23,21 @@   #include <string>   #include <dds/core/macros.hpp>      +#if defined _MSC_VER  +#   pragma warning (push)  +#   pragma warning (disable:4275) // non dll-interface class  'std::foo_error' used as base for dll-interface class 'dds::core::BarError'  +#endif  +   namespace dds { namespace core {         /**  -   * This files contains the exceptions corresponding to DDS errors.  -   * In the DDS-PSM-Cxx in place of DDS errors the associated expcetion  +   * @file  +   * This file contains the exceptions corresponding to DDS errors.  +   * In the DDS-PSM-Cxx in place of DDS errors the associated exception      * should be raised. Please section 7.5.5 of the DDS-PSM-C++  specification.      */      -  class Exception  +  class OMG_DDS_API Exception     {     protected:       Exception();  @@ -42,12 +48,11 @@ namespace dds { namespace core {       virtual const char* what() const throw () = 0;     };      -  class Error : public Exception, public std::exception  +  class OMG_DDS_API Error : public Exception, public std::logic_error     {     public:  -    Error();  +    explicit Error(const std::string& msg);       Error(const Error& src);  -  public:       virtual ~Error() throw ();         public:  @@ -55,7 +60,7 @@ namespace dds { namespace core {     };        -  class AlreadyClosedError : public Exception, public std::logic_error  +  class OMG_DDS_API AlreadyClosedError : public Exception, public  std::logic_error     {     public:       explicit AlreadyClosedError(const std::string& msg);  @@ -67,7 +72,7 @@ namespace dds { namespace core {     };        -  class IllegalOperationError : public Exception, public std::logic_error  +  class OMG_DDS_API IllegalOperationError : public Exception, public  std::logic_error     {     public:       explicit IllegalOperationError(const std::string& msg);  @@ -79,7 +84,7 @@ namespace dds { namespace core {     };        -  class ImmutablePolicyError : public Exception, public std::logic_error  +  class OMG_DDS_API ImmutablePolicyError : public Exception, public  std::logic_error     {     public:       explicit ImmutablePolicyError(const std::string& msg);  @@ -91,7 +96,7 @@ namespace dds { namespace core {     };        -  class InconsistentPolicyError : public Exception, public std::logic_error  +  class OMG_DDS_API InconsistentPolicyError : public Exception, public  std::logic_error     {     public:       explicit InconsistentPolicyError(const std::string& msg);  @@ -103,7 +108,7 @@ namespace dds { namespace core {     };        -  class InvalidArgumentError : public Exception, public  std::invalid_argument  +  class OMG_DDS_API InvalidArgumentError : public Exception, public  std::invalid_argument     {     public:       explicit InvalidArgumentError(const std::string& msg);  @@ -115,7 +120,7 @@ namespace dds { namespace core {     };        -  class NotEnabledError : public Exception, public std::logic_error  +  class OMG_DDS_API NotEnabledError : public Exception, public  std::logic_error     {     public:       explicit NotEnabledError(const std::string& msg);  @@ -127,7 +132,7 @@ namespace dds { namespace core {     };        -  class OutOfResourcesError : public Exception, public std::runtime_error  +  class OMG_DDS_API OutOfResourcesError : public Exception, public  std::runtime_error     {     public:       explicit OutOfResourcesError(const std::string& msg);  @@ -139,22 +144,19 @@ namespace dds { namespace core {     };        -  class PreconditionNotMetError : public Exception, public std::logic_error  +  class OMG_DDS_API PreconditionNotMetError : public Exception, public  std::logic_error     {     public:  -    explicit PreconditionNotMetError(const std::string& msg) :  std::logic_error(msg) { }  -    PreconditionNotMetError(const PreconditionNotMetError& src) :  std::logic_error(src.what()) {}  -    virtual ~PreconditionNotMetError() throw () { }  +    explicit PreconditionNotMetError(const std::string& msg);  +    PreconditionNotMetError(const PreconditionNotMetError& src);  +    virtual ~PreconditionNotMetError() throw ();         public:  -    virtual const char* what() const throw () {  -      return this->std::logic_error::what();  -    }  -  +    virtual const char* what() const throw ();     };        -  class TimeoutError : public Exception, public std::runtime_error  +  class OMG_DDS_API TimeoutError : public Exception, public  std::runtime_error     {     public:       explicit TimeoutError(const std::string& msg);  @@ -166,7 +168,7 @@ namespace dds { namespace core {     };        -  class UnsupportedError : public Exception, public std::logic_error  +  class OMG_DDS_API UnsupportedError : public Exception, public  std::logic_error     {     public:       explicit UnsupportedError(const std::string& msg);  @@ -177,7 +179,7 @@ namespace dds { namespace core {       virtual const char* what() const throw ();     };      -  class InvalidDowncastError : public Exception, public std::runtime_error  +  class OMG_DDS_API InvalidDowncastError : public Exception, public  std::runtime_error     {     public:       explicit InvalidDowncastError(const std::string& msg);  @@ -188,7 +190,7 @@ namespace dds { namespace core {       virtual const char* what() const throw ();     };      -  class NullReferenceError : public Exception, public std::runtime_error  +  class OMG_DDS_API NullReferenceError : public Exception, public  std::runtime_error     {     public:       explicit NullReferenceError(const std::string& msg);  @@ -200,7 +202,7 @@ namespace dds { namespace core {     };        -  class InvalidDataError : public Exception, public std::logic_error  +  class OMG_DDS_API InvalidDataError : public Exception, public  std::logic_error     {     public:       explicit InvalidDataError(const std::string& msg);  @@ -213,4 +215,9 @@ namespace dds { namespace core {       }}      +#if defined _MSC_VER  +#   pragma warning (pop)  +#endif  +  +   #endif /* OMG_DDS_CORE_EXCEPTION_HPP_ */

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18613: API correction required to src/hpp/dds/core/Optional.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Escape '@' annotation in comment      _Suggested resolution_:      diff --git a/src/hpp/dds/core/Optional.hpp b/src/hpp/dds/core/Optional.hpp  index 5e563d0..7f1a1fc 100644  --- a/src/hpp/dds/core/Optional.hpp  +++ b/src/hpp/dds/core/Optional.hpp  @@ -24,7 +24,7 @@ namespace dds { namespace core {         /**      * The optional class is used to wrap attributes annotated with the  -   * @optional annotation. This class provides a simple and safe way of  +   * \@optional annotation. This class provides a simple and safe way of      * accessing, setting and resetting the stored attribute.      */     template <typename T, template <typename Q> class DELEGATE>

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18614: Inconsistent use of Type/type - fix compilation (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Code in src/hpp/dds/core/SafeEnumeration.hpp and  src/hpp/dds/core/policy/PolicyKind.hpp does not compile.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/SafeEnumeration.hpp  b/src/hpp/dds/core/SafeEnumeration.hpp  index 3f7ca67..0d443c2 100644  --- a/src/hpp/dds/core/SafeEnumeration.hpp  +++ b/src/hpp/dds/core/SafeEnumeration.hpp  @@ -3,10 +3,10 @@       namespace dds {     namespace core {  -    template<typename def, typename inner = typename def::type>  +    template<typename def, typename inner = typename def::Type>       class safe_enum : public def       {  -      typedef typename def::type type;  +      typedef typename def::Type type;         inner val;           public:  diff --git a/src/hpp/dds/core/policy/PolicyKind.hpp  b/src/hpp/dds/core/policy/PolicyKind.hpp  index 6928742..9537d78 100644  --- a/src/hpp/dds/core/policy/PolicyKind.hpp  +++ b/src/hpp/dds/core/policy/PolicyKind.hpp  @@ -25,7 +25,7 @@   namespace dds { namespace core { namespace policy {         struct OwnershipKind_def {  -    enum type {  +    enum Type {         SHARED       #ifdef  OMG_DDS_OWNERSHIP_SUPPORT  @@ -37,7 +37,7 @@ namespace dds { namespace core { namespace policy {     typedef dds::core::safe_enum<OwnershipKind_def> OwnershipKind;         struct DurabilityKind_def {  -    enum type {  +    enum Type {         VOLATILE,         TRANSIENT_LOCAL      @@ -46,8 +46,7 @@ namespace dds { namespace core { namespace policy {         TRANSIENT,         PERSISTENT   #endif  // #ifdef  OMG_DDS_PERSISTENCE_SUPPORT  -    };  -  };  +    }; };     typedef dds::core::safe_enum<DurabilityKind_def> DurabilityKind;         struct PresentationAccessScopeKind_def  {  @@ -60,11 +59,11 @@ namespace dds { namespace core { namespace policy {         GROUP   #endif  // OMG_DDS_OBJECT_MODEL_SUPPORT       }; };  -  +  typedef dds::core::safe_enum<PresentationAccessScopeKind_def>  PresentationAccessScopeKind;           struct ReliabilityKind_def {  -    enum type {  +    enum Type {         BEST_EFFORT,         RELIABLE       };  @@ -73,7 +72,7 @@ namespace dds { namespace core { namespace policy {           struct DestinationOrderKind_def {  -    enum type {  +    enum Type {         BY_RECEPTION_TIMESTAMP,         BY_SOURCE_TIMESTAMP       }; };  @@ -81,7 +80,7 @@ namespace dds { namespace core { namespace policy {     typedef dds::core::safe_enum<DestinationOrderKind_def>  DestinationOrderKind;         struct HistoryKind_def {  -    enum type {  +    enum Type {         KEEP_LAST,         KEEP_ALL       };};  @@ -89,7 +88,7 @@ namespace dds { namespace core { namespace policy {     typedef dds::core::safe_enum<HistoryKind_def> HistoryKind;         struct LivelinessKind_def {  -    enum type {  +    enum Type {         AUTOMATIC,         MANUAL_BY_PARTICIPANT,         MANUAL_BY_TOPIC  @@ -97,7 +96,7 @@ namespace dds { namespace core { namespace policy {     typedef dds::core::safe_enum<LivelinessKind_def> LivelinessKind;         struct TypeConsistencyEnforcementKind_def {  -    enum type {  +    enum Type {         EXACT_TYPE_TYPE_CONSISTENCY,         EXACT_NAME_TYPE_CONSISTENCY,         DECLARED_TYPE_CONSISTENCY,

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18615: API corrections required to src/hpp/dds/core/TInstanceHandle.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Incorrect comment.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/TInstanceHandle.hpp  b/src/hpp/dds/core/TInstanceHandle.hpp  index c4c4014..b93975d 100644  --- a/src/hpp/dds/core/TInstanceHandle.hpp  +++ b/src/hpp/dds/core/TInstanceHandle.hpp  @@ -44,7 +44,7 @@ public:     TInstanceHandle(const TInstanceHandle& other);         /**  -   * Distructor  +   * Destructor      */     ~TInstanceHandle();

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18616: API corrections required to src/hpp/dds/core/TQosProvider.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Incorrect comments.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/TQosProvider.hpp  b/src/hpp/dds/core/TQosProvider.hpp  index ef2a3e3..9cdda28 100644  --- a/src/hpp/dds/core/TQosProvider.hpp  +++ b/src/hpp/dds/core/TQosProvider.hpp  @@ -47,8 +47,8 @@ public:      * For instance, the following code:      * <pre><code>            QosProvider  xml_file_provider("file:///somewhere/on/disk/qos-config.xml");  -         QosProvider  json_file_provider(""file:///somewhere/on/disk/json-config.json");  -         QosProvider  json_http_provider(""http:///somewhere.org/here/json-config.json");  +         QosProvider  json_file_provider("file:///somewhere/on/disk/json-config.json");  +         QosProvider  json_http_provider("http:///somewhere.org/here/json-config.json");         </code></pre>          * The URI determines the how the Qos configuration is fetched and the

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18617: Code in src/hpp/dds/core/array.hpp does not compile (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Does not compile      _Suggested resolution_:      diff --git a/src/hpp/dds/core/array.hpp b/src/hpp/dds/core/array.hpp  index cd39d02..dfa910b 100644  --- a/src/hpp/dds/core/array.hpp  +++ b/src/hpp/dds/core/array.hpp  @@ -219,6 +219,8 @@ namespace dds {       template<std::size_t _Int, typename _Tp>          class tuple_element;      +    template <typename _Tp> class tuple_size;  +       template<typename _Tp, std::size_t _Nm>          struct tuple_size<array<_Tp, _Nm> >          { static const std::size_t value = _Nm; };

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18618: API correction required to src/hpp/dds/core/cond/StatusCondition.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Does not compile.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/cond/StatusCondition.hpp b/src/hpp/dds/core/cond/StatusCondition.hpp  index 4e33b3d..e500e39 100644  --- a/src/hpp/dds/core/cond/StatusCondition.hpp  +++ b/src/hpp/dds/core/cond/StatusCondition.hpp  @@ -22,7 +22,7 @@   #include <dds/core/cond/TStatusCondition.hpp>       namespace dds { namespace core { namespace cond {  -  typedef TStatusCondition<detail::StatusCondition> StatusCondition;  +  typedef detail::StatusCondition StatusCondition;   } } }       #endif /* OMG_DDS_CORE_STATUSCONDITION_HPP_ */

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18619: API correction required to src/hpp/dds/core/cond/TWaitSet.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Code does not compile.  Comments incorrect.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/cond/TWaitSet.hpp b/src/hpp/dds/core/cond/TWaitSet.hpp  index dfb05a2..a7fa3ee 100644  --- a/src/hpp/dds/core/cond/TWaitSet.hpp  +++ b/src/hpp/dds/core/cond/TWaitSet.hpp  @@ -22,7 +22,9 @@   #include <vector>       #include <dds/core/types.hpp>  +#include <dds/core/Duration.hpp>   #include <dds/core/cond/Condition.hpp>  +#include <dds/core/cond/WaitSet.hpp>       namespace dds {     namespace core {  @@ -51,11 +53,6 @@ public:     OMG_DDS_REF_TYPE(TWaitSet, dds::core::Reference, DELEGATE)       public:  -  /**  -   * Creates a new waitset.  -   */  -  TWaitSet();  -     ~TWaitSet();       public:  @@ -82,7 +79,7 @@ public:      * @param timeout the maximum amount of time for which the wait      * should block while waiting for a condition to be triggered.      *  -   * @raise PreconditionNotMetException when multiple thread try to invoke  +   * @throws PreconditionNotMetException when multiple thread try to invoke      *        the method concurrently.      *      * @return a vector containing the triggered conditions  @@ -95,11 +92,6 @@ public:      * WaitSet have a trigger_value of TRUE, the wait operation will block      * suspending the calling thread.      *  -   * The wait operation takes a timeout argument that specifies the maximum  -   * duration for the wait. It this duration is exceeded and none of  -   * the attached Condition objects is true, wait will continue and the  -   * returned ConditionSeq will be empty.  -   *      * It is not allowed for more than one application thread to be waiting      * on the same WaitSet. If the wait operation is invoked on a WaitSet that      * already has a thread blocking on it, the operation will raise  @@ -109,10 +101,7 @@ public:      * conditions that have a trigger_value of TRUE (i.e., the conditions      * that unblocked the wait).      *  -   * @param timeout the maximum amount of time for which the wait  -   * should block while waiting for a condition to be triggered.  -   *  -   * @raise PreconditionNotMetException when multiple thread try to invoke  +   * @throws PreconditionNotMetException when multiple thread try to invoke      *        the method concurrently.      *      * @return a vector containing the triggered conditions  @@ -142,7 +131,7 @@ public:      * @param timeout the maximum amount of time for which the wait      * should block while waiting for a condition to be triggered.      *  -   * @raise PreconditionNotMetException when multiple thread try to invoke  +   * @throws PreconditionNotMetException when multiple thread try to invoke      *        the method concurrently.      *      * @return a vector containing the triggered conditions  @@ -173,7 +162,7 @@ public:      * @param timeout the maximum amount of time for which the wait      * should block while waiting for a condition to be triggered.      *  -   * @raise PreconditionNotMetException when multiple thread try to invoke  +   * @throws PreconditionNotMetException when multiple thread try to invoke      *        the method concurrently.      *      * @return a vector containing the triggered conditions  @@ -199,12 +188,12 @@ public:     /**      * A synonym for attach_condition.      */  -  WaitSet& operator +=(const dds::core::cond::Condition& cond);  +  TWaitSet& operator +=(const dds::core::cond::Condition& cond);         /**      * A synonym for detach_condition.      */  -  WaitSet& operator -=(const dds::core::cond::Condition& cond);  +  TWaitSet& operator -=(const dds::core::cond::Condition& cond);         /**      * Attaches a Condition to the WaitSet. It is possible to attach a  @@ -216,7 +205,7 @@ public:      *      * @param cond the condition to be attached to this waitset.      */  -  WaitSet& attach_condition(const dds::core::cond::Condition& cond);  +  TWaitSet& attach_condition(const dds::core::cond::Condition& cond);         /**      * Detaches a Condition from the WaitSet. If the Condition was not

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18620: API correction required to src/hpp/dds/core/cond/detail/GuardCondition.hpp (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

Name:            Simon McQueen  Employer:        PrismTech  Specification:   DDS CXX PSM RTF  FormalNumber:    ptc/12-10-03  Nature:          Revision      _Issues_:      Code incorrect.      _Suggested resolution_:      diff --git a/src/hpp/dds/core/cond/detail/GuardCondition.hpp b/src/hpp/dds/core/cond/detail/GuardCondition.hpp  index a9143fa..fdc8b98 100644  --- a/src/hpp/dds/core/cond/detail/GuardCondition.hpp  +++ b/src/hpp/dds/core/cond/detail/GuardCondition.hpp  @@ -20,13 +20,13 @@    */       #include <dds/core/cond/TGuardCondition.hpp>  -#include <foo/bar/core/cond/GuardConditionImpl.hpp>  +#include <foo/bar/core/cond/GuardCondition.hpp>       namespace dds {     namespace core {       namespace cond {         namespace detail {  -        typedef dds::core::cond::TGuardCondition<foo::bar::core::cond::GuardConditionl> GuardCondition;  +        typedef dds::core::cond::TGuardCondition<foo::bar::core::cond::GuardCondition> GuardCondition;         }       }     }

Resolution:
Revised Text:
Actions taken:
April 3, 2013: received issue

Issue 18625: Example vendor code is incorrect (dds-psm-cxx-rtf)

Click here for this issue's archive.
Source: Micro Focus (Mr. Simon McQueen, simon.mcqueen(at)microfocus.com)
Nature: Revision
Severity:
Summary:

_Suggested resolution_:      diff --git a/src/hpp/dds/core/cond/detail/StatusCondition.hpp b/src/hpp/dds/core/cond/detail/StatusCondition.hpp  index 400c6c8..06f0198 100644  --- a/src/hpp/dds/core/cond/detail/StatusCondition.hpp  +++ b/src/hpp/dds/core/cond/detail/StatusCondition.hpp  @@ -27,7 +27,7 @@ namespace dds {     namespace core {       namespace cond {         namespace detail {  -        typedef dds::core::cond::StatusCondition<foo::bar::core::cond::StatusCondition> StatusCondition;  +        typedef dds::core::cond::TStatusCondition<foo::bar::core::cond::StatusCondition> StatusCondition;         }       }     }